search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.29k stars 648 forks source link

Remove unused `eligibleForNetworking` property #9519

Closed tillh-stripe closed 3 weeks ago

tillh-stripe commented 3 weeks ago

Summary

This pull request removes the unused eligibleForNetworking property, which is being removed on Web and backend as well.

Motivation

Testing

Screenshots

Before After
before screenshot after screenshot

Changelog

github-actions[bot] commented 3 weeks ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.1 KiB │   6.1 KiB │  0 B │   5.8 KiB │   5.8 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -7 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -7 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19906 │ 19906 │ 0 (+0 -0) 
   types │  6163 │  6163 │ 0 (+0 -0) 
 classes │  4954 │  4954 │ 0 (+0 -0) 
 methods │ 29688 │ 29688 │ 0 (+0 -0) 
  fields │ 17374 │ 17374 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────┼───────────┬──────┤ size │ diff │ size │ diff │ path ──────────┼──────┼───────────┼──────┼─────────────────────────────────────────── 25.3 KiB │ -4 B │ 62.8 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 28.4 KiB │ -2 B │ 62.9 KiB │ 0 B │ ∆ META-INF/CERT.SF 270 B │ -1 B │ 120 B │ 0 B │ ∆ META-INF/version-control-info.textproto ──────────┼──────┼───────────┼──────┼─────────────────────────────────────────── 54 KiB │ -7 B │ 125.8 KiB │ 0 B │ (total) ```