stripe / stripe-apps

Stripe Apps lets you embed custom user experiences directly in the Stripe Dashboard and orchestrate the Stripe API.
https://stripe.com/docs/stripe-apps
MIT License
148 stars 73 forks source link

Feature request for SettingsView: Add ability to remove "Save button" #951

Closed bensontrent closed 5 months ago

bensontrent commented 9 months ago

In the app compliance docs for Review Requirements

image

It says we need to only provide one way of saving changes in an app. My app settings page saves each setting to my database on every change, essentially making the save button useless and confusing.

image

To bring my app into compliance with the Review Requirements, I have no control over the display of the save button from the SettingsView component. Is it permissible to use a basic <Box> component for the root view of a settings window or are there some requirements on your side for the root component of this view?

bensontrent commented 7 months ago

You can close this issue. My ignorance didn't know that we could remove the onSave and statusMessage from <SettingsView> to achieve the same effect.