search

stripe / stripe-cli

A command-line tool for Stripe
https://stripe.com/docs/stripe-cli
Apache License 2.0
1.57k stars 362 forks source link

On `stripe login`, fail open when interacting with the keyring #1210

Closed vfcheung closed 3 days ago

vfcheung commented 4 days ago

Reviewers

cc @stripe/developer-products

Summary

This fixes the No directory provided for file keyring issue when trying to run stripe login on WSL. On that system, there may not be a keyring backend, so we fail open to avoid blocking the login flow from completing.

I verified this on Ubuntu 22.04.4 LTS. Our unit tests actually catch this when running make test on this platform, so I also made sure those pass. We should consider ways to handle catching errors like this before they make it into a release.

CLAassistant commented 4 days ago

CLA assistant check
All committers have signed the CLA.