search

stripe / stripe-ios

Stripe iOS SDK
https://stripe.com
MIT License
2.13k stars 982 forks source link

Nested Stripe3DS2.framework breaks app distribution with ERROR ITMS-90205, ERROR ITMS-90206 #1241

Closed olegdanu-newstore closed 5 years ago

olegdanu-newstore commented 5 years ago

Summary

Stripe release Version 16.0.0 introduces support to 3DS2 authentication. It comes as a nested framework inside the main Stripe.framework. This breaks app distribution with errors: ERROR ITMS-90205, ERROR ITMS-90206.

iOS version

12.2

Installation method

SDK version

16.0.0 ## Other information Screen Shot 2019-07-20 at 10 50 15 Screen Shot 2019-07-20 at 10 50 29
yuki-stripe commented 5 years ago

Thanks for reporting this @olegdanu-newstore, we're looking into this.

yuki-stripe commented 5 years ago

@olegdanu-newstore I have a branch that removes Stripe3DS2.framework from Stripe.framework and instead adds it as a Cartfile dependency. This appears to work on my test project, could you try changing your Cartfile to point to yuki-carthage-fix and letting me know if you still run into issues?

I believe you'll need to:

  1. Change your Cartfile line to: github "stripe/stripe-ios" "yuki-carthage-fix"
  2. Drag the Carthage/Build/iOS/Stripe3DS2.framework to Linked Frameworks and Libaries
  3. Add Stripe3DS2 framework to input.xcfilelist, output.xcfilelist
olegdanu-newstore commented 5 years ago

@yuki-stripe looks like your proposed solution resolves the issue. Thanks ;)

olegdanu-newstore commented 5 years ago

@yuki-stripe What are the plans for releasing this?

yuki-stripe commented 5 years ago

@olegdanu-newstore Glad to hear it works!

We're working on a solution that won't require the separate Stripe3DS2 dependency. I'll let you know in this issue when that's ready - you'll probably need to undo what we did here and just update to the latest Stripe version e.g. 16.1.0. I'd recommend waiting until then, but this should work in the mean time if you need it.

yuki-stripe commented 5 years ago

@olegdanu-newstore We just released v16.0.1 that should fix this issue. If that works for you too, can you close this issue? Thanks!

olegdanu-newstore commented 5 years ago

@yuki-stripe thanks for the updates. I am not sure how fast I will be able to test this. So you can consider closing the ticket even before I confirm it working.