Carthage binary support --> Semantic Version strategy

stripe / stripe-ios

Stripe iOS SDK

https://stripe.com

MIT License

2.09k stars 976 forks source link

Carthage binary support --> Semantic Version strategy #1571

Closed dcilia closed 4 years ago

dcilia commented 4 years ago

Summary

If an individual chooses to use Carthage to add the sdk as a dependency using a prebuilt binary in the releases page, the current versioning system is incompatible with Carthage spec.

ie: v19.2.0 is incompatible. https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md#binary-project-specification

Suggestion to adopt Semantic Versioning Model for additionally flexibility and consistency.

Installation method

Carthage

SDK version

Any

Other information

yuki-stripe commented 4 years ago

Hi @dcilia,

Thanks for writing in! I'm not very familiar with this feature of Carthage - why not specify our github repo instead (https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md#github-repositories)?

davidme-stripe commented 4 years ago

Fixing this in #1646

davidme-stripe commented 4 years ago

This is fixed in SDK 20.0.0.