search

stripe / stripe-ios

Stripe iOS SDK
https://stripe.com
MIT License
2.12k stars 981 forks source link

Unable to override brandImageRect #1824

Closed BaluNaik closed 3 years ago

BaluNaik commented 3 years ago

Summary

It seems that it is now impossible to override brandImageRect method. Overriding non-open instance method outside of its defining module

Screen Shot 2021-06-22 at 10 19 10 AM

Code to reproduce

import UIKit
import Stripe

class MyPaymentCardTextField: STPPaymentCardTextField { 

    override func brandImageRect(forBounds bounds: CGRect) -> CGRect {

    }

}

iOS version

14.x

Installation method

Cocoa pod

SDK version

Higher than 21.3.1

Other information

Here is previous discussion Details https://github.com/stripe/stripe-ios/issues/1768

davidme-stripe commented 3 years ago

Thanks for filing this! It should be resolved in 21.7.0.