stripe / stripe-ios

Stripe iOS SDK
https://stripe.com
MIT License
2.1k stars 974 forks source link

[BUG] Wrong title "Front of identity card" #3597

Open googol7 opened 4 months ago

googol7 commented 4 months ago

Summary

We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".

In German this translates to "Vorderseite des Personalausweises" which is not a driving license.

See also:

Version

The problem occurs with stripe-ios 23.27.2

Details

We currently only accept driver's licences by defining options.document.allowed_types = ["driving_license"] when using the API

Available options are:

But in the interface the title is always "Front of identity card".

The text is "Position your identity card in the centre of the frame".

In the code you only use "Front of identity card" here.

iOS Native - English 2


On the first screen you use: "Get ready to scan your photo ID"

iOS Native - English 1

ccen-stripe commented 4 months ago

hi @googol7 We are working on a fix to make this word more generic, will update here

googol7 commented 3 months ago

@ccen-stripe Would it be helpful if we made a PR?

googol7 commented 3 months ago

@ccen-stripe I've seen that you have worked on it in the PR update translation for identity document.

googol7 commented 2 months ago

@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:

  1. Get ready to scan your driver's license Grab your driver's license
  2. Front of driver's license
  3. Flip your ID over Get ready to scan the back of your ID
  4. Back of driver's license

0 1 2 3 4