Concern on 812 Pull request (https://github.com/stripe/stripe-java/pull/812)

stripe / stripe-java

Java library for the Stripe API.

https://stripe.com

MIT License

821 stars 361 forks source link

Concern on 812 Pull request (https://github.com/stripe/stripe-java/pull/812) #822

Closed Thilakeswar closed 5 years ago

Thilakeswar commented 5 years ago

Can anyone please explain more on this issue which has been fixed in this pull request - #812? Am using the stripe-java version 10.9.1 This NPE has been fixed only in the version 10.12.1 If I haven't upgraded to this version, will I face any issues?

ob-stripe commented 5 years ago

@Thilakeswar Only if you use the getRawJsonObject() method, either directly (which is very rarely necessary) or indirectly (typically by using a mapping or serialization library that uses reflection to call all getters, e.g. modelmapper).

That said, it should always be safe to upgrade to a new minor or patch version, i.e. if you're on any 10.x version you can always safely upgrade to the latest 10.x.