Closed Jarred-Sumner closed 3 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
(gentle bump: once you're ready please sign the CLA and this change will be merged!)
Thanks for submitting this. We merged a fix that resolves this issue.
In Bun,
"node:http"
internally is implemented as a wrapper on top offetch
."stripe"
might as well skip the wrapper and just use fetch instead, assuming that it doesn't change the interface for usersIn Bun v1.0, we removed the
"worker"
package.json"exports"
condition which unfortunately caused"stripe"
to load the"node:http"
-based implementation. This"node:http"
-based implementation usually works fine, however there is an edgecase wherehttps.Agent
has the wrongprotocol
set, causing errors when a request is retried. This is a difficult to reproduce bug in Bun and not instripe
, which Bun will fix separately.If we add the
BUN_JSC_dumpModuleLoadingState=1
environment variable, Bun logs some information about which modules have loaded.Bun v0.6.1:
Bun v1.1.7:
We can see that in older versions of Bun, it used the
worker
condition instead of thedefault
condition.I looked through
WebPlatformFunctions.js
and it looks like the main downside to this approach is the lack oftryBufferData
and a slowersecureCompare
. I don't have enough context to know iftryBufferData
is important - it's for file uploads, is what it seems like?