search

stripe / stripe-node

Node.js library for the Stripe API.
https://stripe.com
MIT License
3.9k stars 756 forks source link

Removed qs #2116

Open gkiely opened 5 months ago

gkiely commented 5 months ago

Based off this comment https://github.com/stripe/stripe-node/issues/2038#issuecomment-2004751719

Includes a lightweight alternative to qs.stringify that can run in worker environments. I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

helenye-stripe commented 5 months ago

Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯

chenglou commented 4 months ago

Seems like the only failures are prettier-related?

prathmesh-stripe commented 4 months ago

@chenglou Our CI pipeline does not run the test suite until build failures are resolved first. We are waiting for @gkiely to make progress on this and add rest of the tests that they intend to add in this PR.