search

stripe / stripe-node

Node.js library for the Stripe API.
https://stripe.com
MIT License
3.9k stars 755 forks source link

consider replacing `qs` dependency #2117

Open EddyVinck opened 5 months ago

EddyVinck commented 5 months ago

Is your feature request related to a problem? Please describe.

The qs library includes a lot of polyfills via subdependencies. Polyfills that are required for very old versions of Node.js below the Node.js version that Stripe intends to support (v12 according to the README). These polyfills are likely slowing down the Stripe library unnecessarily.

Describe the solution you'd like

The package is replaced.

Describe alternatives you've considered

-

Additional context

The maintainer of qs is also acting without the interest of his users in mind for a package he just became a maintainer of: https://x.com/Jordy_vD_/status/1804906230940569952

EddyVinck commented 5 months ago

I see there even is a PR for it already https://github.com/stripe/stripe-node/pull/2116