search

stripe / stripe-node

Node.js library for the Stripe API.
https://stripe.com
MIT License
3.9k stars 755 forks source link

Remove TS test that cares about a specific API version #2122

Closed xavdid-stripe closed 5 months ago

xavdid-stripe commented 5 months ago

When releasing the most recent major, the types required a specific API version:

https://github.com/stripe/stripe-node/blob/e219b05f02f09efb57b13e50977012d001a49223/types/lib.d.ts#L30

So this test was failing until we adjusted the string. A test that fails on a schedule isn't great and the test isn't verifying anything especially useful. I think it's more trouble than it's worth, so I pulled it.

ramya-stripe commented 5 months ago

Haha - I was just going to work on this - saw the merge conflicts when I pulled in master :)

Thank you for picking it up!