stripe / stripe-node

Node.js library for the Stripe API.
https://stripe.com
MIT License
3.9k stars 755 forks source link

Add example for Hono #2129

Closed cogoo closed 4 months ago

cogoo commented 4 months ago

Add an example using Hono to the examples folder.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cogoo commented 4 months ago

@prathmesh-stripe are you able to look at this? or to tag the relevant reviewer.

Thanks

cogoo commented 4 months ago

This looks great. Can you please fix the tests?

@prathmesh-stripe

Hey thanks for looking into this. What test are you referring to?

I've added the test to test/Integration.spec.ts it runs successfully ** (on my machine ;P)


edit:

Ohh k, ignore the message above about the tests, I see in the github actions the test is failling. Will take a look 🙏🏾

ramya-stripe commented 4 months ago

@cogoo The tests are still failing - can you take a look?

ramya-stripe commented 4 months ago

@cogoo On second thoughts, looks like this example already exists in https://hono.dev/examples/stripe-webhook

We are closing this PR as we do not see any additional value in adding the same here in our repo as well when users can find it in the hono website itself.