Closed jar-stripe closed 2 weeks ago
Can we rebase this off of master to remove the non-related changes? Other than that 👍
Can we rebase this off of master to remove the non-related changes? Other than that 👍
Done! But this includes a file that shouldn't be there (Margins.d.ts) and will continue to generate until we update the openapi version, so I think this probably needs to wait until that is resolved before we merge.
Why?
The code generator had previously generated resources for V2 services that only contain other services, like V2.Billing, V2.Core, etc. This is undesirable because it produces strangely named files and confusing empty types. This PR updates contains generated code after modifying the code generator to treat these services like namespaces instead of resource-ful services.
This could be a breaking change as the CoreResource.d.ts and BillingResource.d.ts type definitions are being removed. The following therefore would be a type error after this change:
It does not change the access path through StripeClient or the interface of the services, though.
What?
See also
http://go/j/DEVSDK-2196
Changelog
Stripe.V2.BillingResource
,Stripe.V2.CoreResource
, andStripe.V2Resource
types from the public interface as they are no longer needed. SDK usage will not be affected but any references to these types in your application will need to be removed.