Marlrus
commented
3 days ago I've ran some tests and have only managed a middle ground.
I looked at the following comment (https://github.com/stripe/stripe-node/issues/1846#issuecomment-1638595957) which had the following code:
import Stripe from "stripe";
const myHttpClient = Stripe.createNodeHttpClient()
const makeRequest = myHttpClient.makeRequest.bind(myHttpClient)
myHttpClient.makeRequest =(...args) => {
return makeRequest(...args).then((res) => {
if (res.getStatusCode() >= 400) {
callYourCustomErrorHandlerHere(res)
}
return res
})
}}
const stripe = new Stripe("sk_test_xyz", { httpClient: myHttpClient });I applied something similar:
httpClient.makeRequest = (...args) => {
return makeRequest(...args).then((res: Stripe.HttpClientResponse) => {
const stream = res.toStream(() => console.log('STREAM COMPLETED'));
stream.on('end', () => console.log('END'));
stream.on('data', () => console.log('DATA'));
stream.on('response', () => console.log('RESPONSE'));
stream.on('error', () => console.log('ERROR'));
res
.toJSON()
.then((res) => console.log({ res }))
.catch((err) => console.log({ err }))
.finally(() => console.log('FINALLY'));
const raw = res.getRawResponse();
raw.on('end', () => console.log('END'));
raw.on('data', () => console.log('DATA'));
raw.on('response', () => console.log('RESPONSE'));
raw.on('error', () => console.log('ERROR'));
if (res.getStatusCode() > 399) {
throw res;
}
return res;
});
};
this.client = new Stripe(secretKey, { httpClient });With the code above, the following is observed:
res.toJSON()never resolves onthen,catch, orfinally.- Raw response
onevent functions never trigger. toStream(), which returns the raw response as well,onevent functions never trigger and thestreamCompleteCallbackis never called.- Only
getStatusCode()andgetHeaders()work.
I dug into the source code and think the following is happening:
toJSONnever completes because_resno longer has.onevents at that point because theNodeHttpClient.makeRequestfunction is a promise that resolves when the request is completed and the response has already gone through all of the events.
export class NodeHttpClientResponse extends HttpClientResponse {
constructor(res) {
// @ts-ignore
super(res.statusCode, res.headers || {});
this._res = res;
}
getRawResponse() {
return this._res;
}
toStream(streamCompleteCallback) {
// The raw response is itself the stream, so we just return that. To be
// backwards compatible, we should invoke the streamCompleteCallback only
// once the stream has been fully consumed.
this._res.once('end', () => streamCompleteCallback());
return this._res;
}
toJSON() {
return new Promise((resolve, reject) => {
let response = '';
this._res.setEncoding('utf8');
this._res.on('data', (chunk) => {
response += chunk;
});
this._res.once('end', () => {
try {
resolve(JSON.parse(response));
}
catch (e) {
reject(e);
}
});
});
}
}On the flip side, my open telemetry instrumentation for the http package is showing the response body... but I cannot access the data in the server which is where I need it to know how to react to an error.
'@opentelemetry/instrumentation-http': {
responseHook: (span, response: any) => {
try {
if (response.statusCode >= 400 || response.status_code >= 400) {
let body = '';
response.on('data', (chunk: Buffer) => {
body += chunk.toString();
});
response.on('end', () => {
span.setAttribute('http.response.body', body);
response.removeAllListeners();
});
}
if (response.statusCode > 499 || response.status_code > 499) {
span.setStatus({
code: Otel.SpanStatusCode.ERROR,
message: response.message || response.statusMessage || 'No error message',
});
}
} catch (err) {
console.log(err);
span.setStatus({
code: Otel.SpanStatusCode.ERROR,
message: 'OTEL instrumentation-http responseHook Error',
});
}
},
},As it stands now, I am in the following situation:
- Error responses are at least throwing.
- OTEL instrumentation can catch the error response bodies.
- I cannot access error details in code.
- All errors are the same in my
catchblocks:
{
"info": {
"scope": "POST::/api/v1/subscriptions::SubscriptionService::createSubscription",
"name": "Error",
"message": "An error occurred with our connection to Stripe. Request was retried 2 times.",
"stack": "Error: An error occurred with our connection to Stripe. Request was retried 2 times.\n at /app/node_modules/stripe/cjs/RequestSender.js:401:41\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
},
"level": "error",
"message": "An error occurred with our connection to Stripe. Request was retried 2 times.",
"trace_id": "f6d9cd02242b57463ba2d9d2619978fc",
"span_id": "898804a2e1e6b5cc",
"trace_flags": "01"
}
jar-stripe
AntonioAngelino
Describe the bug
Within NestJS, when performing calls such as
StripeClient.invoices.createor other operations with bad data, requests hang indefinitely and don't throw errors.To Reproduce
new Stripe(<API_KEY>)try/catchblockinvoices.createmethod with an invalid payload (Such as the one in the snippet)Expected behavior
When an API call fails on any non
2xxstatus, it should throw an exception that can be caught by atry/catchblock or a.catch.Code snippets
OS
Running on Docker
linux/amd64 node:20-alpineNode version
Node v20.18.0
Library version
stripe node version 17.3.0
API version
Default (Whatever you get when you don't specify any)
Additional context
Noticed running in a NestJS Application running in docker.
I've tried:
httpClientproperty innew Stripewith Axios and NestJS default HTTP Clients, to no avail.I also tried writing a script with the exact same code on the exact same version of node on a loose
.tsfile and running it withts-nodeand it worked.I'll keep plowing through as it is critical for me to know when Stripe operations fail. If I find a solution, I will post it here.