search

stripe / stripe-php

PHP library for the Stripe API.
https://stripe.com
MIT License
3.73k stars 849 forks source link

Stripe on FuelPHP #16

Closed thpoul closed 12 years ago

thpoul commented 12 years ago

I have created a package on FuelPHP for stripe and encountered the following error while using the simplistic example provided in the README (I was using my own key).

Runtime Notice!

ErrorException [ Runtime Notice ]: Declaration of Stripe_SingletonApiResource::_scopedRetrieve() should be compatible with that of Stripe_ApiResource::_scopedRetrieve()

PKGPATH/stripe/vendor/Stripe/SingletonApiResource.php @ line 24:
23: }
24: }

Notice: Undefined offset: 25 in /fuel/packages/stripe/vendor/Stripe/SingletonApiResource.php on line 24
25:
ebroder commented 12 years ago

Hmm, sorry about that - we'll take a look.

For our own testing, what version of PHP are you using?

We added SingletonApiResource fairly recently, so you can grab a slightly older version as a stop gap. https://code.stripe.com/stripe-php-1.7.2.tar.gz or https://code.stripe.com/stripe-php-1.7.2.zip should work

thpoul commented 12 years ago

Well, this was fast! Problem solved! Thank you very much.

I'm using PHP 5.4 on Ubuntu 12.04 and FuelPHP is a PHP 5.3 framework.

ebroder commented 12 years ago

Bah, I never manage to get the commit to close the issue.

In any case, I've just released a version 1.7.5 of stripe-php that should be clean under E_STRICT, and I've made sure our test suite runs with E_STRICT in the future so we catch these issues.

New release should be available at https://code.stripe.com/stripe-php-latest.tar.gz or https://code.stripe.com/stripe-php-latest.zip

Thanks for letting us know about this!