search

stripe / stripe-php

PHP library for the Stripe API.
https://stripe.com
MIT License
3.75k stars 848 forks source link

Examples are basically non-existent #1767

Closed php4fan closed 1 month ago

php4fan commented 1 month ago

Describe the bug

Why even have an "examples" directory if it's going to contain this kind of ****?

new_example.php is especially ridiculous. Just delete it.

To Reproduce

...

Expected behavior

...

Code snippets

No response

OS

all

PHP version

irrelevant

Library version

latest

API version

wtf

Additional context

No response

remi-stripe commented 1 month ago

@php4fan There's no need to be impolite while reporting an issue. Those examples are here to explain how to use the SDK itself and make API requests, they aren't canonical examples on how to integrate our products and APIs. We have numerous end-to-end guides in our docs and we also maintain canonical samples in https://github.com/stripe-samples that you can look at.

I'm going to close this as it's not really conducive to a positive interaction.

php4fan commented 1 month ago

Can you explain exactly what purpose the file new_example.php serves?

I'm pretty sure the answer is "none" (even from the standpoint of what you have clarified is the intent of the examples), in which case I really think it would be better to remove it.

remi-stripe commented 1 month ago

I do plan to audit the examples, just preferred to close this issue based on tone!