search

stripe / stripe-python

Python library for the Stripe API.
https://stripe.com
MIT License
1.64k stars 418 forks source link

Create a type alias for `stripe.TaxId.type` and others #1324

Open hofrob opened 4 months ago

hofrob commented 4 months ago

Is your feature request related to a problem? Please describe.

I want to re-use the long list of VAT types for my internal methods. Currently, they are copy pasted throughout the library. This means there's no way to just re-use them as a type alias.

Describe the solution you'd like

Create a typing.TypeAlias with the string literals and expose it.

Describe alternatives you've considered

Creating a type alias from the existing class properties did not work. This might be because of my limited understanding of how type hints can be re-used or extracted from external libraries.

Additional context

No response

hofrob commented 4 months ago

It might make sense to rewrite these methods to use StrEnums instead.

xavdid-stripe commented 4 months ago

Thanks for flagging! This is something I'll look into.

xavdid-stripe commented 3 months ago

@hofrob Can you tell us more about your use case here? You're correct that it's not easy to extract that type, but it's something we can probably surface.