stripe / stripe-python

Python library for the Stripe API.
https://stripe.com
MIT License
1.64k stars 418 forks source link

don't auto-organize imports #1357

Closed xavdid-stripe closed 2 months ago

xavdid-stripe commented 2 months ago

Minor VSCode settings tweak to reduce noise in PRs.

I like auto-formatted imports, but our imports are not currently sorted (as far as VSCode is concerned). I was finding that auto-sorting added a lot of noise to PRs when I was working in unsorted files. Plus, this is a VS-code specific operation, so if team members use a different editor, imports would be unsorted until a VSCode user happened to work on the same file.

A better solution would ruff to handle the import sorting, which all editors (and tooling) will pick up and help us maintain. But that's slightly more involved, so short term I figured disabling the behavior was simpler.

If you want to sort imports manually, you can still run VSCode's Organize Imports command.