search

stripe / stripe-react-native

React Native library for Stripe.
https://stripe.dev/stripe-react-native
MIT License
1.28k stars 263 forks source link

Support Fabric components #1275

Open benomatis opened 1 year ago

benomatis commented 1 year ago

I'm on RN 0.71.1 and have activated the new architecture and am receiving the message 'CardField' is not fabric compatible yet in place of the actual CardField component.

Is it in the pipeline to make it compatible? This is only an issue in Android, in iOS it works fine.

charliecruzan-stripe commented 1 year ago

Yes it's in the pipeline, we'll be migrating all components + the module to turbomodules

benomatis commented 1 year ago

Cheers, Thank you @charliecruzan-stripe!

smiley717 commented 1 year ago

image

I'm using RN 0.71.4 and when I'm trying to add stripe CardFiled There is an issue, Is this still pending?

smiley717 commented 1 year ago

What is the solution, here? I cannot use react native stripe element? @charliecruzan-stripe

benomatis commented 1 year ago

@smiley717 sadly the only way to work around this is turn off the new architecture - not great, but it's the only way I could make CardFiled work. Again, this was only an issue in Android for me:

android/gradle.properties:

# Use this property to enable support to the new architecture.
# This will allow you to use TurboModules and the Fabric render in
# your application. You should enable this flag either if you want
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false
# -> this here ^^^^^
smiley717 commented 1 year ago

@benomatis Thank you for your kind help, By turning it off this, it will affect to other rendering capabilities?

smiley717 commented 1 year ago

Turning off this field is raising another compile issue. :/

benomatis commented 1 year ago

@smiley717 You'd have to test it for yourself; my app already existed before the new architecture came with 0.68, so I had no real impact turning it back off.

Your other compile issue may or may not be related to the new architecture, it can be many things, but it's not really the scope of this issue.

smiley717 commented 1 year ago

Thanks a lot!

smiley717 commented 1 year ago

image

I was only able to fix this issue by disable newArchEnabled at the moment.

sabuhiteymurov commented 4 months ago

Any updates? With the new architecture becoming the default standard, is it still not planned?

amol-ghotankar commented 1 month ago

New architecture is now default in react native so we should except company like stripe which is tech first payment company to solve these issues sooner and be the leadership in this space, its surprising this issue is open since 8 months with no or little traction.