search

stripe / stripe-react-native

React Native library for Stripe.
https://stripe.dev/stripe-react-native
MIT License
1.25k stars 256 forks source link

Font names with underscores incorrectly throw an error on Android in PaymentSheet #1636

Open goguda opened 4 months ago

goguda commented 4 months ago

Describe the bug

When trying to use a font name with an underscore on Android in the appearance parameter for PaymentSheet, an error is incorrectly resolved:

_Encountered an error when setting a custom font: appearance.font.family should only contain lowercase alphanumeric characters on Android, but received 'crimsonprobold'. This value must match the filename in android/app/src/main/res/font.

This is not accurate as Android font names may have underscores in them as well, in addition to lowercase alphanumeric characters.

To Reproduce

Steps to reproduce the behavior:

  1. Put an underscore in the name of any custom font in android/app/src/main/res/font (ex. crimsonpro_regular.ttf)
  2. Specify the font name with underscore when initializing PaymentSheet

Expected behavior

Font names with underscores should be accepted as well on Android, in addition to lowercase alphanumeric characters.

Smartphone (please complete the following information):

Additional context

I've already tested simply bypassing the if statement that checks for this and the font displays on the PaymentSheet correctly.

The fix will simply involve changing the regex expression in android/src/main/java/com/reactnativestripesdk/PaymentSheetAppearance.kt to allow for underscores. I will create a PR soon

goguda commented 4 months ago

PR #1637

MariuzM commented 1 month ago

For me similar

Encountered an error when setting a custom font: appearance.font.family should only contain lowercase alphanumeric characters on Android, but received 'Figtree'. This value must match the filename in android/app/src/main/res/font

For now i fixed like so.

image
danieloliverdevika commented 2 weeks ago

Experiencing the same issue here for a font named asap_regular.ttf as of @stripe/stripe-react-native version 0.38.4. Implementing the change made in https://github.com/stripe/stripe-react-native/pull/1637 as a manual patch with pnpm patch @stripe/stripe-react-native is working so far. Would be nice to see this one merged.