search

stripe / stripe-ruby

Ruby library for the Stripe API.
https://stripe.com
MIT License
1.96k stars 548 forks source link

Update generated code #1419

Closed stripe-openapi[bot] closed 4 months ago

stripe-openapi[bot] commented 4 months ago

Codegen for openapi v1093.

Changelog

This release changes the pinned API version to 2024-06-20. Please read the API Upgrade Guide and carefully review the API changes before upgrading.

Additions

WillRogers727 commented 3 months ago

@ramya-stripe I can see a breaking change in the description here, but the code doesn't appear to reflect that change. Has the change been pushed elsewhere or was the description included unintentionally?

ramya-stripe commented 3 months ago

Ah, that was my mistake That breaking change was part of another PR

https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md#1200---2024-06-24 has the complete changelog

fschwahn commented 3 months ago

@ramya-stripe I'm having a hard time understanding the breaking change in v12 of the gem. Looking at https://my.diffend.io/gems/stripe/11.7.0/12.0.0 there don't seem to be any changes to the retrieve-method at all. Can you shed some light what we should be looking out for?

ramya-stripe commented 3 months ago

@fschwahn You are right. Looks like we missed merging those changes to master branch. We were referring to https://github.com/stripe/stripe-ruby/pull/1423

So, the only breaking change left is that the v12 of the package now uses a new API version which brings breaking changes in behavior as described in the API Upgrade Guide

@prathmesh-stripe Can you please update the changelog and the release tag https://github.com/stripe/stripe-ruby/releases/tag/v12.0.0? And re-open the internal ticket we have for this change to be included in the next major release?

fschwahn commented 3 months ago

@ramya-stripe thanks for clearing that up!