search

stripe / stripe-terminal-android

Stripe Terminal Android SDK
https://stripe.dev/stripe-terminal-android/
Other
93 stars 45 forks source link

Stripe localmobile 2.22.0 leads to build errors #349

Closed TatsuUkraine closed 1 year ago

TatsuUkraine commented 1 year ago

Summary

After updating localmobile deps to 2.22.0 Android build fails with an error

Duplicate class org.bouncycastle.jce.provider.BouncyCastleProvider found in modules jetified-bcprov-jdk15on-1.70 (org.bouncycastle:bcprov-jdk15on:1.70) and jetified-stripeterminal-localmobile-2.22.0-runtime (com.stripe:stripeterminal-localmobile:2.22.0)
Duplicate class org.bouncycastle.pqc.jcajce.provider.BouncyCastlePQCProvider found in modules jetified-bcprov-jdk15on-1.70 (org.bouncycastle:bcprov-jdk15on:1.70) and jetified-stripeterminal-localmobile-2.22.0-runtime (com.stripe:stripeterminal-localmobile:2.22.0)

Code to reproduce

Android version

Impacted devices (Android devices or readers)

SDK version

2.22.0

Other information

In the app we have Stripe Terminal SDK and Stripe SDK. All works fine with v2.21.*

rv-stripe commented 1 year ago

@TatsuUkraine Are you able to reproduce this issue in our example application and provide the full error?

TatsuUkraine commented 1 year ago

@rv-stripe you just need to install Stripe SDK alongside with Stripe Terminal SDK

rv-stripe commented 1 year ago

We're tracking this and should have a fix for the next release.

TatsuUkraine commented 1 year ago

Thanks you!

yogen-p commented 1 year ago

Eagerly waiting for this to be fixed 🤞🏼

rv-stripe commented 1 year ago

This issue should be fixed in the latest release. Please let me know if you still have issues.

TatsuUkraine commented 1 year ago

Yep, sorry, forgot to close it. Thank you!