stripe / stripe-terminal-ios

Stripe Terminal iOS SDK
https://stripe.com/docs/terminal/sdk/ios
Other
104 stars 65 forks source link

Long SPM checkout time (big repo size) #331

Open TomaszLizer opened 3 weeks ago

TomaszLizer commented 3 weeks ago

Summary

Adding stripe-terminal-ios to project takes quite a bit of time and is a burden on CI. Currently repo uses 1.15 GiB which is main source of the issue.

Since stripe-terminal-ios is already distributed as xcframework it is quite easy to create lightweight mirror optimised for SPM. This can be achieved eg by copying Package.swift file and commiting it to separate repo on each release. This can be also automated. In order to optimise usage of this framework I have prepared such mirror on my account which could be used as example :) It can be found here: https://github.com/TomaszLizer/stripe-terminal-ios-spm This mirror uses github CI to periodically check source repo for updates. If found it automatically copies Package.swift and creates release :)

Code to reproduce

N/A

iOS version

Any version

Installation method

Swift Package Manager

SDK version

Any version

Other information

bric-stripe commented 3 weeks ago

Hi just acknowledging we understand and agree this should be done. We plan to eventually have a mirror similar to what you setup and what we have for the payments SDK @ https://github.com/stripe/stripe-ios-spm 👍 Will update this ticket when we have updates.