search

stripe / stripe-terminal-react-native

React Native SDK for Stripe Terminal
https://stripe.com/docs/terminal/payments/setup-integration?terminal-sdk-platform=react-native
MIT License
113 stars 50 forks source link

[deadline] Google Play Store requires targetSdkVersion to be 34 or higher by August 31, 2024 #753

Closed nabilfreeman closed 3 months ago

nabilfreeman commented 4 months ago

Describe the bug Update your target API level by August 31, 2024 to release updates to your app

We've detected that your app is targeting an old version of Android. To provide users with a safe and secure experience, Google Play requires all apps to meet target API level requirements.

From August 31, 2024, if your target API level is not within 1 year of the latest Android release, you won't be able to update your app.

To Reproduce Steps to reproduce the behavior:

  1. Follow the instructions in the readme and set targetSdkVersion to 33
  2. Submit an application to the Google Play Store

Expected behavior This behaviour is expected, due to the current issues with SDK 34 and Stripe Terminal:

https://github.com/stripe/stripe-terminal-react-native?tab=readme-ov-file#android

https://github.com/stripe/stripe-terminal-android/issues/387

Questions:

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2024-07-08 at 11 15 15

Stripe Terminal React Native SDK version

Additional context

I understand the library is still in beta, and we really do appreciate you having this out there for us to use in the meantime!

nazli-stripe commented 4 months ago

that issue has been fixed since v0.0.1-beta.15, looks like we forgot to update the Readme. Can you set the target to 34 on the latest version?

nabilfreeman commented 4 months ago

Thanks for the update @nazli-stripe, I'll give it a try. Are the custom build settings generally still required? Assume yes, because we still need to force the minimum SDK version to 26?

shreyaspathak11 commented 4 months ago

How to solve this if my app is build with react native expo

Ryanhuang1124 commented 4 months ago

Is it ok that I only update target sdk but no changes on compileSdk(because newer compileSdk version makes app crush) ?

ebarrenechea-stripe commented 4 months ago

@Ryanhuang1124 yes, you can set different values for targetsdk and compilesdk. You can set targetsdk to 34 while keeping compilesdk on 33. I'd also advice you run the app on an Android 14 device/emulator to ensure everything works fine. And, as @nazli-stripe mentioned above, our SDK is compatible with API 34 since the v0.0.1-beta.15 release.

patmisch commented 2 months ago

I'm running version 0.0.1-beta.12, which does not seem to work (cannot discover readers) if targetSdkVersion is set to 34. I upgraded to version 0.0.1-beta.15, but this seems to depend on a newer version of react native, that I do not have the time to upgrade to, due to how many dependencies I have that it ends up breaking.

Am I completely out of luck here and need to upgrade react native? Or is there a work around that will allow me to get a small update to my app published to the Play Store?