[QR] add support for QR fields

stripe / stripe-terminal-react-native

React Native SDK for Stripe Terminal

https://stripe.com/docs/terminal/payments/setup-integration?terminal-sdk-platform=react-native

MIT License

110 stars 50 forks source link

[QR] add support for QR fields #827

Closed henryx-stripe closed 1 month ago

henryx-stripe commented 1 month ago

Summary

Add fields for wechat_pay on react native

Motivation

With release of 3.9, qr support in SDKs is available

Testing

[x] I tested this manually
[x] I added automated tests

Documentation

Select one:

[ ] I have added relevant documentation for my changes.
[ ] This PR does not result in any developer-facing changes.

tim-lin-bbpos commented 1 month ago

UI test seems fail due to we modify/affect the existing flow: https://app.bitrise.io/build/3b40e92d-0092-4e01-b819-885bc4c32836

tim-lin-bbpos commented 1 month ago

btw, there're few useful command can run the test locally like yarn lint to avoid waiting the result on the remote CI. https://github.com/stripe/stripe-terminal-react-native/blob/main/CONTRIBUTING.md

henryx-stripe commented 1 month ago

https://github.com/user-attachments/assets/59ba598f-9193-451c-8437-efbd23131e02

@tim-lin-bbpos can you help investigate why the bitrise build is failing. Previously, the only thing I changed was adding another row the the CollectPayment Screen (which should not break the tests), but the test harness seems to be very buggy, and when it tries to scroll to the bottom, it doesn't work properly. So i made the collect button static on the screen (always appear at the bottom) so that no scrolling is required, but it still does not work on the CI, it works fine for me on local.