search

stripe / subprocess

A port of Python's subprocess module to Ruby
MIT License
209 stars 17 forks source link

Fix #25: stop Subprocess::Process#communicate from leaking open FDs. #26

Closed rbroemeling closed 6 years ago

andrew-stripe commented 7 years ago

@rbroemeling: What do you think about an implementation where catching_sigchld invokes the block form of IO.pipe and yields the read side to the block?

rbroemeling commented 7 years ago

@andrew-stripe I'm having trouble imagining a use for that. What's the intention of that implementation?

andrew-stripe commented 7 years ago

Just to encapsulate the cleanup logic into catching_sigchld rather than forcing the caller to manage it.

rbroemeling commented 7 years ago

@andrew-stripe Sure, I think that makes sense.

russelldavis commented 6 years ago

What do you think about an implementation where catching_sigchld invokes the block form of IO.pipe and yields the read side to the block?

I implemented the fix in that form at #31

andrew-stripe commented 6 years ago

Fixed in #33