stripe / subprocess

A port of Python's subprocess module to Ruby
MIT License
209 stars 17 forks source link

Handle EPIPE in handle_sigchld. #28

Closed nelhage-stripe closed 7 years ago

nelhage-stripe commented 7 years ago

It's not at present entirely clear how this can happen; My best theory involves forking-with-active-threads, which is unsafe in other ways. However, this patch seems ~clearly correct; If the reader has gone away for whatever reason, it should be safe to drop the wakeup.

r? @andrew-stripe

andrew-stripe commented 7 years ago

👍