Closed laurenl-stripe closed 1 year ago
This lets us override the ServerName we share in TLS. This gets configured here: https://github.com/grpc/grpc-go/blob/master/credentials/tls.go#L69
Setting an explicit servername is advantageous when there are one or more proxies in between the veneur proxy and client.
/opt/homebrew/bin/go test -timeout 30s -run ^(TestGetTlsConfig|TestGetTlsConfigNoServerName|TestGetTlsConfigMissingField|TestGetTlsConfigEmpty|TestGetTlsConfigUnset)$ github.com/stripe/veneur/v14/util/tls
@arnav-stripe to help with this post-merge!
Summary
This lets us override the ServerName we share in TLS. This gets configured here: https://github.com/grpc/grpc-go/blob/master/credentials/tls.go#L69
Motivation
Setting an explicit servername is advantageous when there are one or more proxies in between the veneur proxy and client.
Test plan
Rollout/monitoring/revert plan
@arnav-stripe to help with this post-merge!