striris / pe

0 stars 0 forks source link

borrow date exceed 7 days is accepted #3

Open striris opened 2 years ago

striris commented 2 years ago

image.png

The maximum date cannot exceed 7 days but this bug is encountered.

soc-se-bot commented 2 years ago

Team's Response

Start date of borrowing should have been counted for in borrowing duration.

Users will still be able to use the product and does not render the product unusable. The program still checks if there's inventory within the timeframe before borrowing out.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

date error and vague available borrow amount

image.png First, this is not showing errors about the date restriction, which is quite severe. Second, the system doesn't tell me how many items I can borrow. Reduce by how much? It would be good if you can add the amount here :)


[original: nus-cs2113-AY2122S2/pe-interim#353] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Agree with the first comment by the tester. An error should have been thrown first on the date restrictions.

The second comment by the tester is not in scope for v2.1 and a potential improvement in next iterations.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: The severity is very high as a person can borrow an item for an infinite period of time. Which is definitely going to cause issues for the system and user. Making the system not usable.