search

strkfarm / starkfarm-client

https://www.strkfarm.xyz/
GNU Affero General Public License v3.0
17 stars 30 forks source link

feature: Add Hashstack Base APY #156

Open akiraonstarknet opened 1 month ago

akiraonstarknet commented 1 month ago

Is your feature request related to a problem? Please describe. At present, hashstack pools listed do not have base APYs shown. We need to work on it to fix that.

Describe the solution you'd like Use the logic used by hashstack to compute their apyBase here to embed logic into our platform. https://github.com/0xHashstack/yield-server/blob/8498cd35ba7e38a7d2333d186b5d3d94e5653e4f/src/adaptors/hashstack/index.js

Iwueseiter commented 1 month ago

Hi @akiraonstarknet can I work on this? I will look at https://github.com/0xHashstack/yield-server/blob/8498cd35ba7e38a7d2333d186b5d3d94e5653e4f/src/adaptors/hashstack/index.js. Then implement a logic that retrieves the APY values and integrate them into the store's state management system. I will add the Hashstack Base APY within hashstack.store.ts.

ETA: 2 to 3 days.

akiraonstarknet commented 1 month ago

@Iwueseiter @ShantelPeters please share details of your implementation. (E.g. the files & functions you will modify) to achieve this. Also mention timeline.

akiraonstarknet commented 1 month ago

Hi @akiraonstarknet

To address the missing base APY display for StarkDefi pools, i will conduct research on StarkDefi's official website to understand their APY calculation methodology. Then I will adapt this logic to the issue. Going forward I will take the following steps regarding the my implementation ;

  • Firstly I will reverse-engineer StarkDefi's APY calculation logic
  • Then identify and integrate required data points (interest rates, compounding frequency, etc.)
  • Also develop and test the adapted APY calculation function
  • Then lastly display base APYs alongside StarkDefi pools .

Timeline: 3-5 working days…

@ShantelPeters sorry to say this, but we cannot accept your request. Yesterday you had mentioned an incorrect approach and today's updated comment fully involves writing about StarkDefi instead of Hashstack. Third, you havent mentioned files or functions as well. Thank you, please try some other issue once they open.

akiraonstarknet commented 1 month ago

@Iwueseiter why to look at network tab, when I shared their APY calculation logic file? They use it in their defillama calcs. You could simply use that with some modifications relevant to us.

Iwueseiter commented 1 month ago

@Iwueseiter why to look at network tab, when I shared their APY calculation logic file? They use it in their defillama calcs. You could simply use that with some modifications relevant to us.

Noted. I will look at the file.