search

strkfarm / starkfarm-client

https://www.strkfarm.xyz/
GNU Affero General Public License v3.0
17 stars 28 forks source link

bug: remove ekubo price api dependency #170

Closed akiraonstarknet closed 1 week ago

akiraonstarknet commented 2 weeks ago

Describe the bug ekubo integration uses ekubo price info. This price feed will be taken down soon and we have to switch to our internal feed.

Solution This code points to where price feed is used. All /price feed APIs through ekubo need to removed. https://github.com/strkfarm/starkfarm-client/blob/7255242a05b75bb31a8e70bdae45633405be824d/src/store/ekobu.store.ts#L359

Use the following function to get price instead https://github.com/strkfarm/starkfarm-client/blob/7255242a05b75bb31a8e70bdae45633405be824d/src/utils.ts#L150

Benjtalkshow commented 2 weeks ago

Hello @akiraonstarknet Can i be assigned to this task? I will carefully fix the bug. Thank you

martinvibes commented 2 weeks ago

hello @akiraonstarknet i would love to work on this issue :)

Kaminar-i commented 2 weeks ago

hey @akiraonstarknet can i be assined this issue?

0xdevcollins commented 2 weeks ago

@akiraonstarknet Can I be assigned this issue? I'll get it done as soon as possible.

ooochoche commented 1 week ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a returning contributor

How I plan on tackling this issue

I have gone through the reference github links and I plan on approaching the issue like this:

deeseeker commented 1 week ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I'm Qudus Adeyemi, a front-end developer with 2 years of experience in React, TypeScript, and JavaScript, specializing in building pixel-perfect, interactive user interfaces. During the previous OD Hackathon, I contributed by enhancing the Starknet React documentation and implementing the useWatchAssets hook to improve wallet tracking. I also have strong experience with React Query and have successfully applied it in various projects to handle complex use cases.

I’m genuinely excited about this opportunity to deepen my knowledge of Web3 technologies and to contribute to your project. I believe my experience, enthusiasm for learning, and problem-solving skills would make me a strong fit for this task.

I estimate the task will take around 1-2 days to complete and I would love the chance to collaborate with the team. Thank you for considering my application!

How I plan on tackling this issue

  1. Clone the project to my local machine.
  2. Set up the project by following the provided documentation.
  3. Review the existing codebase.
  4. Plan the debug.
  5. Implement plan.
  6. Thoroughly test to ensure it functions as expected.
  7. Document the hook for future reference and ease of use.
akiraonstarknet commented 1 week ago

@Benjtalkshow can u finish this today? its a little urgent

Benjtalkshow commented 1 week ago

Alright