strohel / Ceygen

Cython helper for linear algebra with typed memoryviews built atop of Eigen C++ library
MIT License
36 stars 5 forks source link

Ceygen incompatible with Eigen3.2.5 #5

Closed Dapid closed 9 years ago

Dapid commented 9 years ago

The problem is in the last function in lu.pyx

Here is the build log: https://gist.github.com/Dapid/94cff5f6f3b4124a23da

My guess is that the problem is somewhere in the MSDispatcher:

cdef cppclass MSDispatcher[Scalar]:
    void run(Scalar *x_data, Py_ssize_t *x_shape, Py_ssize_t *x_strides,
             Scalar *o,
             void (*c)(Scalar *, Py_ssize_t *, Py_ssize_t *, CContig, Scalar *) nogil,
             void (*f)(Scalar *, Py_ssize_t *, Py_ssize_t *, FContig, Scalar *) nogil,
             void (*n)(Scalar *, Py_ssize_t *, Py_ssize_t *, NContig, Scalar *) nogil,
    ) nogil except +

But I don't know what dies it correspond to in Eigen to check if there has been any changes.

Dapid commented 9 years ago

Found the problem. It is not the dispatcher, it is the function that computes the determinant, that no longer accepts int types. I have a fix, submitting a PR.