Fix export for csv - Githubissues

strohne / Facepager

Facepager was made for fetching public available data from YouTube, Twitter and other websites on the basis of APIs and webscraping.

https://github.com/strohne/Facepager/releases

506 stars 198 forks source link

Closed siscia closed 5 years ago

siscia commented 5 years ago

This PR I believe fix export into CSV.

It is been manually tested in Linux, hence some problem may arise if used in a different platform (issues could also be on Linux itself XD).

I removed a method that I didn't see used anywhere else.

siscia commented 5 years ago

Cheers!

About the BOM it seems that is not simple to write it into a non-binary file. It is needed? Actually is the first time I see it around.

For the delimiter I haven't test it with the tab delimiter, I would be a little surprised if it didn't work. I will take another look tomorrow.

The string/utf8/encoding stuff along with the changes in the CSV modules were indeed quite a mess in the python 2 -> 3 migration!

Cheers!

strohne commented 5 years ago

Well, the BOM in combination with tab or semicolon delimiter is needed for convincing Excel to read UTF-8 out of the box.

strohne commented 5 years ago

Should work now. Thank you very much for testing and fixing! The hunt for bugs will continue. Cheers!