search

strongback / strongback-java

A library for FIRST Robotics Competition robots that makes it easier to write and test your robot code.
MIT License
41 stars 38 forks source link

Issue 111 - Support CommandGroups in CommandTester #113

Open rothso opened 7 years ago

rothso commented 7 years ago

This PR addresses #111 and moves the buildRunner method from Scheduler into CommandRunner so CommandTester can also correctly execute CommandGroups.

To keep the code clean, I've adjusted the CommandRunner to expose two static builders:

These builders call into buildRunner. After some refactoring, I was left with only two CommandRunner constructors. Both are only used by the buildRunner so I made them private. Regression/integration tests included. Let me know what you think and if there's anything you'd like me to change. Thanks!

agausmann commented 7 years ago

@rhauch What do you think? We never provided feedback on the original issue, but this seems like a feature that should be implemented.