search

strongback / strongback-java

A library for FIRST Robotics Competition robots that makes it easier to write and test your robot code.
MIT License
41 stars 38 forks source link

fixed AsyncSwitchReactor not updating listeners #61

Closed xortive closed 8 years ago

xortive commented 8 years ago

new Containers are now added to listeners Container correctly updates its integral listeners.

fixes #60.

bdavies01 commented 8 years ago

We implemented these changes, and AsyncSwitchReactors are now functional.

rhauch commented 8 years ago

@granjef3: Thanks for the submission. Unfortunately, your PR file reformats the AsyncSwitchReactor.java file, so most of the changes to the file have nothing to do with the bug fix. Any chance you are willing to resubmit this so that only the 4 affected lines are changed? See my line note above for a far more compact way of doing the same thing that your fix did.

rhauch commented 8 years ago

@granjef3: Actually, never mind about resubmitting. I'll deal with the formatting changes in a separate PR that builds on top of your changes. Thanks!

Look for a new Strongback release later today!

rhauch commented 8 years ago

Closing without merging. Instead, PR #63 incorporates the commit from this PR while removing the unnecessary formatting changes and simplifying the logic of the fix by using lambdas (see above).