strongback / strongback-java

A library for FIRST Robotics Competition robots that makes it easier to write and test your robot code.
MIT License
41 stars 38 forks source link

Fix a few things about Logitech joysticks #79

Closed plusparth closed 8 years ago

plusparth commented 8 years ago

I don't have access to the Extreme 3D joystick in person now, so I'm not sure if any of its axes are supposed to be reversed. I'm just going off of our code from last season which used it. If they are supposed to be reversed, I can change it.

rhauch commented 8 years ago

Thanks for the pull request!

rhauch commented 8 years ago

I don't have access to the Extreme 3D joystick in person now, so I'm not sure if any of its axes are supposed to be reversed. I'm just going off of our code from last season which used it. If they are supposed to be reversed, I can change it.

It would be better if you (or someone else) can verify the mappings, since they're easy to get wrong. Anybody willing to verify this code with actual hardware?

plusparth commented 8 years ago

@rhauch I'm almost positive the mappings are correct, since I'm going off of the code we used during the competition last season. I will be able to access the hardware around September, so I can verify the mappings then if you want.

rhauch commented 8 years ago

@plato2000, we can go with the current mappings and deal with any problems if they arise later. I would like to keep the code backward compatible, though, so can you please revert the method rename as I described above?

plusparth commented 8 years ago

Oh sorry, I misunderstood what you said, I'll revert the method name instead of just deprecating it.

agausmann commented 8 years ago

I will be able to verify the mapping with my Extreme 3D when I get back home on Sunday.