strongback / strongback-java

A library for FIRST Robotics Competition robots that makes it easier to write and test your robot code.
MIT License
41 stars 38 forks source link

Mock solenoids #86

Closed FilipKernan closed 7 years ago

FilipKernan commented 7 years ago

The instantaneousSolenoid() method and the manualSolenoid() return essentially the same object. From what I have gathered from the code is that the manualSolenoid() should be set to false. `/**

rhauch commented 7 years ago

@FilipKernan, yeah, I think you're right. The manualSolenoid method should call new MockSolenoid(false);. Do you want to submit a pull request? (If so, please feel free to add your name to the CONTRIBUTORS file in the root of the repository in a second commit within the same pull request.)

FilipKernan commented 7 years ago

@rhauch sure. Will do.

rhauch commented 7 years ago

Fixed by #87