strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.33k stars 102 forks source link

Manage (Fav)icons in the macOS App #267

Open dan-el opened 4 years ago

dan-el commented 4 years ago

It would be great if we could manage the Favicons and other database entry icons/pictures in the password database through the Strongbox UI. At the moment it's possible to add new icons using the "Select from File..." and "Find Favicon(s)..." buttons in the edit icon screen.

Something like a right click menu to remove existing icons would be nice there. Maybe drag and drop support as well? It should also warn the user if an icon that is about to be removed is still linked with a database entry. Maybe it can even report on non-linked icons and purge them through the click of another button? Maybe this all needs a separate UI part altogether - something like "(Fav)icon Manager"? This "Icon Manager" could also allow to "bulk replace" icons meaning that it could replace one icon for another in all associated database entries with the single click of a button.

This would allow to keep the database clean and small and would squash the need to go to a Windows PC with KeePass for these tasks.

mmcguill commented 4 years ago

Thanks @dan-el - An Icon manager would be useful I think.

Just so you know, Strongbox trims/cleans up the Icon pool every time it saves. This means if there are any unused icons (not referenced by any entry or historical entry) that icon will be removed from the pool. This should keep your database size to a minimum.

It is probably also worth running maintenance on your database every now and then with the KeePass client to trim historical entries and other cruft that accumulates.

dan-el commented 4 years ago

File size is only one of my concerns. But good to know that an automatic purge is happening.

May I suggest that this is being moved into a configurable setting that defaults to OFF. While I see the benefit of making efforts to keep the database size low I don't like the idea of automatic purges without user notifications in general. I think users prefer to know what's happening.

What do you mean by "trim"? If that means something like changing icon size/resolution/sth. similar I'd also suggest moving this to a configurable setting. No preference towards this option's default value.

It might only be me but I certainly love to manage my entry icons manually. Favicons usually do not provide icons that are suitable for high dpi screens like the ones on MacBooks (and iDevices), hence I cannot use the recently introduced Favicon support.

Is Strongbox on macOS not deleting history items as configured in the database settings? I wasn't aware of this at all.

Thanks for your reply!

mmcguill commented 4 years ago

May I suggest that this is being moved into a configurable setting that defaults to OFF.

A config for this might make sense I guess, but default to OFF does not seem like a good idea in my opinion. People just expect unused and duplicates to be rationalized and tidied, as they do with File Attachments.

What do you mean by "trim"?

Trim means removing unused and duplicate icons (binary identical icons). No changes to sizes/resolutions.

Is Strongbox on macOS not deleting history items as configured in the database settings? I wasn't aware of this at all.

Strongbox on Mac and iOS is respecting your history settings and deleting as configured.

dan-el commented 4 years ago

Thanks for clarifying the trim and history questions.

The feature request comes down to this in the end:

Add an "Icon Manager" to the macOS App with the following capabilities:

mmcguill commented 4 years ago

Ok, thanks for the suggestion @dan-el