strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.33k stars 102 forks source link

Custom Fields #656

Closed PingSoup closed 1 year ago

PingSoup commented 1 year ago

Hello, would it be possible to make couple of enhancements to the Custom Fields. IMO, these are more of usability enhancements than cosmetics.

1) It would be very useful if one can change the order of Custom Fields as they appear (as list view), so that I can have to most used Custom Field at the top, or in a desired order. 2) Currently, the title of the Custom Fields are in grey, less prominent than the values in the Custom Fields. IMO, it should be the other way around. I would like see the title of the Custom Field more prominent. That way I can quickly see the Custom Field I am looking for and then look up the value in the field.

PingSoup commented 1 year ago

Sorry correcting/editing #1).. " so that I am able to move the most used Custom Field to the top"

strongbox-mark commented 1 year ago

Hi @PingSoup - You should be able to do 1) already, just disable:

Settings > Advanced > Sort Custom Fields

Then you can go to the edit screen and drag and drop to re-order the fields.

For 2, ok thanks interesting, we might be able to fit this in with Font Size changes/configurability.

PingSoup commented 1 year ago

Hi @strongbox-mark - Thank you for reply. "Sort Custom Fields" is enabled "green", however, in edit mode, the feature is not working on iOS and macOS. Currently there is no way to move or reorder the fields.

strongbox-mark commented 1 year ago

Hi @PingSoup - Can you disable/uncheck the "Sort Custom Fields" checkbox, then you will be able to manually drag/drop the fields.

svoop commented 1 year ago

@strongbox-mark Is this a beta feature as of now? Can't seem to find it in 1.56.6.

strongbox-mark commented 1 year ago

Hi, yes, it is, it's on the Database Settings > Advanced screen at the bottom. Turn it off to allow custom ordering... This will be surfaced better in the next release, it'll be directly on the Details pane to toggle between Ascending or Custom order...

svoop commented 1 year ago

@strongbox-mark It works pretty well on macOS, however, there is one nasty oddity.

Given the following ordered (sort: custom) custom fields:

image

Now double click on the first custom field name "aaa" and edit that very name from "aaa" to "aaa2", this field is moved automatically to the end thus messing up the custom sorting:

image

Expected behavior: The ordering should remain, "aaa2" should still be first of the list.

(Btw, what do you prefer in such a case: You reopening the existing issue or shall I create a new issue in the future?)

strongbox-mark commented 1 year ago

I see, must be a relic of how we're doing the editing, it's a deletion and then an addition when you edit a field name... Pretty small one, but it would be nice to fix... It's always best to open new issues and keep them as small and atomic as possible. But for now, I'll try fix this up in the next release.

strongbox-mark commented 1 year ago

Hi @svoop - This should be fixed for you in 1.57.3. To download and update to 1.57.3, you will need to go to the App Store, search for Strongbox, click on the correct version (the one you have installed now) and then you will see the "Update" button. Click that to Update :)

Could you confirm and close?

svoop commented 1 year ago

@strongbox-mark Looking good, thanks a bunch! (However, I can't close the issue, you'd have to do it it seems.)

strongbox-mark commented 1 year ago

Cool, thanks!