search

strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.35k stars 102 forks source link

Feature: Custom field grouping (low hanging fruit) #660

Open svoop opened 2 years ago

svoop commented 2 years ago

With #656 (almost) out of the way, there might be an easy to impement solution for grouping custom fields. Here's an example:

Given an (ordered) list of custom fields:

image

The items without value could be considered group titles and therefore rendered differently in the view. This way, no changes are necessary on the underlying kdbx structure, but the 1Password importer can take a leap forward and maintain ordering and grouping with group titles of custom fields.

Also, the behavior complies with the principle of least surprise: Custom fields without a value are not rendered (since they don't carry a payload) unless when sorting is custom.

With "sort: custom", these group titles are rendered upcased+bold and the function icons are omitted:

custom

With "sort: ascending", the group titles are not rendered at all.

image
strongbox-mark commented 2 years ago

That is an interesting idea, I don't hate it... It would be a non standard extension though so I'm always a little dubious, I don't want to place work on devs of other KeePass compatible apps. Worth considering though... Thanks.

svoop commented 2 years ago

Since it doesn't break anything existing, maybe worth asking upstream whether it could make the specs for kdbx. This under the assumption that ordered custom items are part of these very specs and not an addition of Strongbox which isn't stored in the kdbx itself.