strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.35k stars 102 forks source link

Implement a custom copy type #665

Closed francescotarantino closed 1 year ago

francescotarantino commented 1 year ago

Hi, I'm using Maccy to keep log of my clipboard and I added the Strongbox app to the ignored app list. Unfortunately, this solution doesn't work 100% of the time (sometime I find some of my passwords in my clipboard history). I found out that if Strongbox used a custom copy type when copying a password, it could be set in the ignored list (https://github.com/p0deje/Maccy#ignore-custom-copy-types), and this solution should work 100% of the time.

strongbox-mark commented 1 year ago

I believe we tried this before and it broke regular copy/paste, and I believe it was for Maccy too. I can't remember the exact details but it seems setting a custom copy type isn't so straightforward. There's more info here: https://github.com/p0deje/Maccy/issues/125

georgesnow commented 1 year ago

I believe if you are just looking for clipboard managers to ignore copies. You set the type to conceal Maccy and other clipboard managers will honor the conceal type and ignore them from their history tracking

syntax isn’t perfect but basically you have to attach secondary pasteboard type which is “conceal” (there are others like transient) in addition to string utf8 type


NSString* type = [NSPasteboard.generalPasteboard setString: @"" forType:NSPasteboardTypeString];
NSPasteboard*  pb  = [NSPasteboard generalPasteboard];
[NSPasteboard.generalPasteboard clearContents];
[pb setString:"" forType:"org.nspasteboard.ConcealedType"]
[pb setString:@"concealme" forType:type]
strongbox-mark commented 1 year ago

Yes, I think we tried that before or something very similar... I can try again and put it behind an Advanced Preference defaulted OFF for the next release and then you can play with it and see if it works ok/doesn't break things...

strongbox-mark commented 1 year ago

Hi @francescotarantino and @georgesnow - This is now available for test as 1.57.3 on the App Store. There's an advanced preference for this.

Please do let me know how it goes.

To download and update to 1.57.3, you will need to go to the App Store, search for Strongbox, click on the correct version (the one you have installed now) and then you will see the "Update" button. Click that to Update :)

francescotarantino commented 1 year ago

Hi, thank you for your quick response. I'm testing it right now and it seems to work correctly!

strongbox-mark commented 1 year ago

That's great, we'll wait on @georgesnow to confirm and close.

strongbox-mark commented 1 year ago

Believe this one is fixed. Closing out.