search

strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.34k stars 102 forks source link

Tag separator interoperability: `,` not recognized #671

Closed vszakats closed 1 year ago

vszakats commented 1 year ago

Strongbox recognizes ; as a tag separator (in line with the available informal KDBX specs).

The issue is that despite the spec, some clients (notably KeePassXC and keepassxc-cli) are saving tags with comma , separators. Opening such database in Strongbox results in a single concatenated tag for each entry, which is not usable: Screen Shot 2022-12-25 at 15 03 07 vs the expected: Screen Shot 2022-12-25 at 15 26 31

Other clients resolve this by recognizing multiple tag separators:

I wonder if Strongbox would be willing to also accept at least , (comma) for better tag interoperability with other clients?

strongbox-mark commented 1 year ago

Yes, not a bad idea, probably best to include all three separators for maximum compatibility.

vszakats commented 1 year ago

Thank you for implementing this in v1.58.0. Tag splitting now works perfectly in my tests (tested with ;).

strongbox-mark commented 1 year ago

Yes, no problem :) One thing to note, I don't think KeePassXC is splitting on colon (:) despite that link above to their code. We've had a contact from one user mentioning this. I still think the right thing to do is maximize compatibility with other clients by splitting on all 3 delimiters. You may want to ping the KeePassXC crew about this.

vszakats commented 1 year ago

I'm happy with semicolons alone. Though one thing worthy to contact the KeePassXC crew is to include these details in the non-official specs.

Also thanks for the upgrade overall, it's a quite solid one!