strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.33k stars 102 forks source link

No Close button or icon after creating and commiting a new entry #674

Closed elharo closed 1 year ago

elharo commented 1 year ago
  1. Create a new account entry
  2. Set up passwords and username et al as needed.
  3. Press Commit (not commit and close)

There's now no obvious way to close the dialog. In fact, one has to press "cancel" but "Cancel" does not mean close. Cancel is assumed to mean cancel the operation — that is, don't create the entry.

Either give the dialog a close button or better yet a platform appropriate close icon on the window or both.

strongbox-mark commented 1 year ago

Hi there, that doesn't sound right and we're not seeing that on the latest build on the App Store (1.57.3).

There's a blue Close button at the bottom you can click after step 3. What version are you running there? or would you be able to provide a screen recording/screenshot of the issue?

Also, hitting cancel in this scenario (or pressing Esc) is equivalent to close. Commit means commit, so you can uncommit from that point.

elharo commented 1 year ago

I'll check on version details and let you know.

There is a meta-issue in play here. "Commit" is not a verb that's meaningful to non-technical end users. Ditto "Record", "Entry", and other similar database terms. The UI seems to expose implementation details in multiple places. Probably the best equivalent for an end user here is "Save".

elharo commented 1 year ago

The app seems to prevent itself from being screen captured but I'll push something through the analog hole. Meanwhile.

Strongbox 1.56.2 Debug Information at 2023-01-01 17:42:39.916

App Version: com.markmcguill.strongbox [1.56.2 (5024)]


Device

Model: Mac13,1 CPU: ARM64E System Name: MacOS System Version: Version 12.6.2 (Build 21G320)

elharo commented 1 year ago

IMG-4187

strongbox-mark commented 1 year ago

OK, thanks for that. Could you update to the latest on the App Store, there were some improvements to this UI over the last while. Hopefully should ameliorate some of your concerns.

strongbox-mark commented 1 year ago

Believe this is fixed. Closing out now.