search

strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.3k stars 100 forks source link

iOS: faulty search results with keyword "git" in search query #684

Closed marcusique closed 1 year ago

marcusique commented 1 year ago

I have a separate database with TOTP only. Whenever I want to find a TOTP for Github and enter "git" in the search field, the app returns all available TOTP entries. Same behavior on macOS as well. IMG_381D83FE7781-1 DB format: KeePass 2 (4.0) App: 1.58.7 OS: iOS 16.3.1

strongbox-mark commented 1 year ago

Wow, interesting find. I think what's happening here is it is finding "git" inside the OTPAuth URL for TOTPs. This URL contains a parameter called "digits" which is matching. I think we'll need to add some special search code to avoid matching on these params.

marcusique commented 1 year ago

Works now. Thanks!