strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.35k stars 102 forks source link

iOS issue with copy TOTP to clipboard #736

Closed JLWFuQrioea69ugsykvQcg closed 1 year ago

JLWFuQrioea69ugsykvQcg commented 1 year ago

I'm using the latest version of the Strongbox app on iOS 17.1.1. The copy TOTP to clipboard functionality doesn't seem to be working once I select the entry for auto fill. I do have the option enabled under auto fill settings. I've tried turning off auto fill and toggling that option but it's still not working. By not working I mean it's not copying the TOTP code to the clipboard because when I go to paste it's blank. Any suggestions?

strongbox-mark commented 1 year ago

Oh that's weird, have you tried a full device restart?

JLWFuQrioea69ugsykvQcg commented 1 year ago

I did do that as well yesterday with no change. This morning while testing it worked as expected the first time. Subsequent times it failed to update the TOTP code stored on the clipboard so it was using the code from the first time. Now it entered the username and password, but doesn't store anything to the clipboard so there's nothing to paste. Yeah, so now it's back to not working and I've tried different entries. Sometimes when I select "paste" it pastes my password from the entry I just auto filled.

Quick update: I switched the auto fill to a test database and the entry worked the first time with the TOTP code. I waited more than 30 seconds, and then tried it again and it failed to update the code that's on the clipboard and tried to use the old code which was expired.

JLWFuQrioea69ugsykvQcg commented 1 year ago

I also tried it on my iPhone 14 running 17.1 and it's exhibiting the same behavior where it works the first time and subsequent tries fails.

strongbox-mark commented 1 year ago

Is this happening inside Safari or is it a third party app?

JLWFuQrioea69ugsykvQcg commented 1 year ago

My issue has been in safari. I haven't tried this in a third party app.

strongbox-mark commented 1 year ago

Do you have "AutoFill convenience unlock timeout" switched on, and, does turning that off improve things?

JLWFuQrioea69ugsykvQcg commented 1 year ago

I had it turned on and set for the 10 min. I turned it off and it seems to work more consistently now. I'll experiment with it on my work phone and let you know.

SyntaxSnack commented 1 year ago

I have the same exact issue, and I sent an email with a full screen recording and more extensive info to support@strongboxsafe.com from lmaevan@icloud.com titled BUG Report: copy TOTP on autofill doesn't work, sometimes freezes

iOS 17.2 Developer Beta FYI

Safari as well, but will test on other browsers tomorrow

strongbox-mark commented 1 year ago

Thanks @eyeseaevan - Got your mail, will investigate... Could you do the same as above:

Do you have "AutoFill convenience unlock timeout" switched on, and, does turning that off improve things?

strongbox-mark commented 1 year ago

HI @JLWFuQrioea69ugsykvQcg @eyeseaevan - This should be fixed now with the release of 1.58.33, could you check/confirm?

SyntaxSnack commented 1 year ago

HI @JLWFuQrioea69ugsykvQcg @eyeseaevan - This should be fixed now with the release of 1.58.33, could you check/confirm?

Hey @strongbox-mark , sorry I wasn't able to reported on the suggested bug fix of setting convenience autolock to a shorter value. Anyway, on the previous release I disabled the convenience autolock and this seemed to fix the issue.

I just updated to the latest release and set convenience autolock to the longest value of 3 days and tested several sites including nextdns - which I had used as an example in my bug report email. It looks to be working well now. No freezing, the autofill is quick, and the clipboard is updated with the totp / 2fa code.

If I later find any bugs with it I'll report, but it seems that this update has fixed it 🙂 Thank you

JLWFuQrioea69ugsykvQcg commented 1 year ago

@strongbox-mark I'm only seeing 1.58.32 in the US iOS App Store at the time of this post. Maybe there's a delay in availability for me. I'll check it after the update comes available.

strongbox-mark commented 1 year ago

Sorry, .32 should also have the fix, .33 is on the way, waiting for Apple review

strongbox-mark commented 1 year ago

Hi @JLWFuQrioea69ugsykvQcg - Could you update to 1.58.35 and let me know if this fixes things for you?

JLWFuQrioea69ugsykvQcg commented 1 year ago

Same comment as #729 :-)

Thankfully I have not experienced any auto type or quick fill issues in the past few builds. I appreciate you putting the time and effort into to resolving these issues. Thank you!