Open carlspring opened 5 years ago
@ptirador : Would you like to take the part regarding the web form tests?
@carlspring: Yes, I'll take them. BTW, great work with the test list!
Thanks! :)
Feel free to pick any other tests, if you want to.
@fuss86:
Do we need these tests and are they ever enabled:
MavenArtifactIndexControllerTest
MavenSearchControllerTest
Would you mind reminding me how these worked and whether we disabled them...? (I remember we agreeded to drop the Maven Indexer support, apart from the generation of packed Maven Indexes).
Thanks! :)
Note: Issue #957 is required to be resolved for some of the remaining tests to be finished.
MavenArtifactIndexControllerTest
is disabled by default. You can run it using command:
mvn test -pl strongbox-web-core -Dtest=MavenArtifactIndexControllerTest -Dmaven.indexer.enabled=true
or by adding this line <maven.indexer.enabled>true</maven.indexer.enabled>
to the strongbox-web-core/pom.xml
in the maven-surefire-plugin
area.
I see it needs some adjustments to work now.
We disabled this test when we decided to disable maven indexer support (in the currently implemented form). See SB-1103 for reference.
MavenSearchControllerTest
has 2 tests and testIndexSearches
is disabled by default under the same conditions as explained above.
@fuss86 : Thanks for reminding me about this! I don't think we need to do anything about these tests then.
The test cases in this module are taking quite a long time, as they're all running consecutively.
With our upgrade of JUnit to JUnit5 (handled by @ptirador in #871), we now have the means to further fine-tune the parallelization of our tests.
The current time to build, including the integration tests (before the refactoring):
Requirements
org.carlspring.strongbox.web.DirectoryTraversalFilterTest
org.carlspring.strongbox.validation.users.PasswordValidatorTest
org.carlspring.strongbox.security.authentication.suppliers.CustomLoginSupplierTest
org.carlspring.strongbox.security.CustomAccessDeniedHandlerTest
org.carlspring.strongbox.controllers.TrashControllerTest
org.carlspring.strongbox.controllers.configuration.ArtifactCoordinateValidatorsManagementControllerTest
org.carlspring.strongbox.controllers.configuration.security.ldap.LdapAuthenticatorConfigurationControllerTest
org.carlspring.strongbox.controllers.configuration.security.cors.CorsConfigurationControllerTest
org.carlspring.strongbox.controllers.AccountControllerTest
org.carlspring.strongbox.controllers.BrowseControllerTest
org.carlspring.strongbox.controllers.PingControllerTest
org.carlspring.strongbox.controllers.login.LoginControllerTest
org.carlspring.strongbox.controllers.aql.AqlControllerTest
org.carlspring.strongbox.controllers.SpringSecurityTest
org.carlspring.strongbox.controllers.TrashControllerUndeleteTest
org.carlspring.strongbox.controllers.layout.raw.RawArtifactControllerTest
org.carlspring.strongbox.controllers.layout.nuget.NugetArtifactControllerTest
org.carlspring.strongbox.controllers.layout.maven.MavenMetadataManagementControllerTest
@fuss86:org.carlspring.strongbox.controllers.layout.maven.MavenSearchControllerTest
@fuss86:org.carlspring.strongbox.controllers.layout.maven.MavenArtifactIndexControllerTest
org.carlspring.strongbox.controllers.layout.maven.MavenArtifactControllerTest
org.carlspring.strongbox.controllers.layout.npm.NpmArtifactControllerTest
org.carlspring.strongbox.controllers.CustomAntPathMatcherTest
org.carlspring.strongbox.controllers.users.PasswordEncoderControllerTest
org.carlspring.strongbox.AssetsManifestTest
org.carlspring.strongbox.forms.users.AccessModelFormTestIT
org.carlspring.strongbox.forms.RoleListFormTestIT
org.carlspring.strongbox.forms.configuration.StorageFormTestIT
org.carlspring.strongbox.forms.configuration.RemoteRepositoryFormTestIT
org.carlspring.strongbox.forms.configuration.ProxyConfigurationFormTestIT
org.carlspring.strongbox.forms.configuration.SmtpConfigurationFormTestIT
org.carlspring.strongbox.forms.configuration.ServerSettingsFormTestIT
org.carlspring.strongbox.forms.configuration.RepositoryFormTestIT
org.carlspring.strongbox.forms.RoleFormTestIT
org.carlspring.strongbox.forms.storage.routing.RoutingRuleFormTestIT
org.carlspring.strongbox.forms.storage.routing.RuleSetFormTestIT
org.carlspring.strongbox.forms.PrivilegeFormTestIT
org.carlspring.strongbox.forms.PrivilegeListFormTestIT
org.carlspring.strongbox.forms.users.RepositoryAccessModelFormTestIT
org.carlspring.strongbox.forms.users.UserFormTestIT
org.carlspring.strongbox.controllers.forms.FormDataControllerTestIT
org.carlspring.strongbox.controllers.environment.EnvironmentInfoControllerTestIT
org.carlspring.strongbox.controllers.configuration.security.authorization.AuthorizationConfigControllerTestIT
org.carlspring.strongbox.controllers.configuration.security.authentication.AuthenticatorsConfigControllerTestIT
org.carlspring.strongbox.controllers.configuration.ServerConfigurationControllerTestIT
org.carlspring.strongbox.controllers.configuration.StoragesConfigurationControllerTestIT
org.carlspring.strongbox.controllers.configuration.RoutingConfigurationControllerTestIT
org.carlspring.strongbox.controllers.configuration.HttpConnectionPoolConfigurationManagementControllerTestIT
org.carlspring.strongbox.controllers.configuration.StrongboxConfigurationControllerTestIT
org.carlspring.strongbox.controllers.configuration.ProxyConfigurationControllerTestIT
org.carlspring.strongbox.controllers.LoggingManagementControllerTestIT
org.carlspring.strongbox.controllers.layout.raw.RawArtifactControllerTestIT
org.carlspring.strongbox.controllers.layout.npm.NpmArtifactControllerTestIT
org.carlspring.strongbox.controllers.users.UserControllerTestIT
: The tests are running in parallel now, but there needs to be a@BeforeAll
, (or something), that cleans up before the tests, as it's otherwise not possible to re-run the tests in an IDE, without them failing after succeeding the first time.Notes
This task is a sub-task of #839. For reference of how things should be done, you can have a look at #936.