Make the strongbox-web-core's tests work in parallel

[carlspring]

The test cases in this module are taking quite a long time, as they're all running consecutively.

With our upgrade of JUnit to JUnit5 (handled by @ptirador in #871), we now have the means to further fine-tune the parallelization of our tests.

The current time to build, including the integration tests (before the refactoring):

[INFO] Strongbox: Web Core ................................ SUCCESS [02:24 min]

Requirements

• Each test method of each test must now take care of creating its own test resources and not rely on them to be created by a common test initialization method, or other test methods.
• Test cases which require a repository, should create the repository in each test method and not rely on them to be created by a common test initialization method, or other test methods.
• Unit tests
  • [x] org.carlspring.strongbox.web.DirectoryTraversalFilterTest
  • [x] org.carlspring.strongbox.validation.users.PasswordValidatorTest
  • [x] org.carlspring.strongbox.security.authentication.suppliers.CustomLoginSupplierTest
  • [x] org.carlspring.strongbox.security.CustomAccessDeniedHandlerTest
  • [x] org.carlspring.strongbox.controllers.TrashControllerTest
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.ArtifactCoordinateValidatorsManagementControllerTest
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.security.ldap.LdapAuthenticatorConfigurationControllerTest
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.security.cors.CorsConfigurationControllerTest
  • [x] org.carlspring.strongbox.controllers.AccountControllerTest
  • [ ] @ptirador: org.carlspring.strongbox.controllers.BrowseControllerTest
  • [x] org.carlspring.strongbox.controllers.PingControllerTest
  • [x] org.carlspring.strongbox.controllers.login.LoginControllerTest
  • [x] org.carlspring.strongbox.controllers.aql.AqlControllerTest
  • [x] org.carlspring.strongbox.controllers.SpringSecurityTest
  • [x] org.carlspring.strongbox.controllers.TrashControllerUndeleteTest
  • [x] org.carlspring.strongbox.controllers.layout.raw.RawArtifactControllerTest
  • [x] org.carlspring.strongbox.controllers.layout.nuget.NugetArtifactControllerTest
  • [x] org.carlspring.strongbox.controllers.layout.maven.MavenMetadataManagementControllerTest
  • [x] @fuss86: org.carlspring.strongbox.controllers.layout.maven.MavenSearchControllerTest
  • [x] @fuss86: org.carlspring.strongbox.controllers.layout.maven.MavenArtifactIndexControllerTest
  • [ ] org.carlspring.strongbox.controllers.layout.maven.MavenArtifactControllerTest
  • [x] org.carlspring.strongbox.controllers.layout.npm.NpmArtifactControllerTest
  • [x] org.carlspring.strongbox.controllers.CustomAntPathMatcherTest
  • [x] org.carlspring.strongbox.controllers.users.PasswordEncoderControllerTest
  • [x] org.carlspring.strongbox.AssetsManifestTest
• Integration Tests
  • [x] @ptirador: org.carlspring.strongbox.forms.users.AccessModelFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.RoleListFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.StorageFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.RemoteRepositoryFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.ProxyConfigurationFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.SmtpConfigurationFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.ServerSettingsFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.configuration.RepositoryFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.RoleFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.storage.routing.RoutingRuleFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.storage.routing.RuleSetFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.PrivilegeFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.PrivilegeListFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.users.RepositoryAccessModelFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.forms.users.UserFormTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.forms.FormDataControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.environment.EnvironmentInfoControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.security.authorization.AuthorizationConfigControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.security.authentication.AuthenticatorsConfigControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.ServerConfigurationControllerTestIT
  • [ ] @carlspring: org.carlspring.strongbox.controllers.configuration.StoragesConfigurationControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.RoutingConfigurationControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.HttpConnectionPoolConfigurationManagementControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.StrongboxConfigurationControllerTestIT
  • [x] @ptirador: org.carlspring.strongbox.controllers.configuration.ProxyConfigurationControllerTestIT
  • [x] @carlspring: org.carlspring.strongbox.controllers.LoggingManagementControllerTestIT
  • [x] org.carlspring.strongbox.controllers.layout.raw.RawArtifactControllerTestIT
  • [x] org.carlspring.strongbox.controllers.layout.npm.NpmArtifactControllerTestIT
  • [ ] @ptirador: org.carlspring.strongbox.controllers.users.UserControllerTestIT : The tests are running in parallel now, but there needs to be a @BeforeAll, (or something), that cleans up before the tests, as it's otherwise not possible to re-run the tests in an IDE, without them failing after succeeding the first time.

Notes

• The web form tests should all be quick wins and should be able to work out of the box.

This task is a sub-task of #839. For reference of how things should be done, you can have a look at #936.

[carlspring]

@ptirador : Would you like to take the part regarding the web form tests?

[ptirador]

@carlspring: Yes, I'll take them. BTW, great work with the test list!

[carlspring]

Thanks! :)

Feel free to pick any other tests, if you want to.

[carlspring]

@fuss86:

Do we need these tests and are they ever enabled:

• MavenArtifactIndexControllerTest
• MavenSearchControllerTest

Would you mind reminding me how these worked and whether we disabled them...? (I remember we agreeded to drop the Maven Indexer support, apart from the generation of packed Maven Indexes).

Thanks! :)

[carlspring]

Note: Issue #957 is required to be resolved for some of the remaining tests to be finished.

[fuss86]

MavenArtifactIndexControllerTest is disabled by default. You can run it using command:

mvn test -pl strongbox-web-core -Dtest=MavenArtifactIndexControllerTest -Dmaven.indexer.enabled=true

or by adding this line <maven.indexer.enabled>true</maven.indexer.enabled> to the strongbox-web-core/pom.xml in the maven-surefire-plugin area.

I see it needs some adjustments to work now.

We disabled this test when we decided to disable maven indexer support (in the currently implemented form). See SB-1103 for reference.

MavenSearchControllerTest has 2 tests and testIndexSearches is disabled by default under the same conditions as explained above.

[carlspring]

@fuss86 : Thanks for reminding me about this! I don't think we need to do anything about these tests then.