search

strongdm / accessbot

Manage access to strongDM resources via Slack
Apache License 2.0
23 stars 19 forks source link

SDM_COMMANDS_ENABLED - Code doesn't match Documentation #194

Closed stevekoskie closed 2 years ago

stevekoskie commented 2 years ago

From the Documents: SDM_COMMANDS_ENABLED. AccessBot commands to be enabled. Default = access_resources assign_role show_resources show_roles

The code in the config.py looks for "access_resource" not "access_resources". However, since show_resources is plural and access_resource is singular I wasn't sure which way you ultimately want it.

camposer commented 2 years ago

Thank you very much @stevekoskie for noticing the issue and letting us know. We just updated the docs, the correct setup would be:

SDM_COMMANDS_ENABLED. AccessBot commands to be enabled. Default = access_resource assign_role show_resources show_roles approve

In case you want to take a look at the code: https://github.com/strongdm/accessbot/blob/main/config.py#L4