Closed jwdink closed 1 year ago
@andywong36 OK, this was tricky, but I have a 2nd stab at this, take a look at the updated description above, and the updated PR.
Now that we have is_classifier
, I no longer have an excuse not to support R^2 scoring for non-classifiers 😬
@jwdink I'd like to hold off on this review until I complete #16 so I can better understand what's going on.
supports_predict_proba
toFamily
total_count
parameter. For distributions like binomial/multinomial, it doesn't make sense to train on / predict classes, because this won't capture heterogeneous countsLabelEncoder
does the work. if not (e.g. multinomial) you have to pass aN*num_classes
array fory
which contains the countsResolves https://github.com/strongio/foundry/issues/14