strongio / foundry

MIT License
3 stars 0 forks source link

Remove set on copy using `inplace=True` #35

Open andywong36 opened 5 months ago

andywong36 commented 5 months ago

Currently getting this warning.

https://github.com/strongio/foundry/blob/a4bb55ed81c4bfe0dd2fc75eda3610d671dfbd62/foundry/evaluation/marginal_effects.py#L492

/home/__REDACTED__/lib/python3.9/site-packages/foundry/evaluation/marginal_effects.py:492: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.
The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.

For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.